[Okular-devel] Review Request 122787: Saves the state, if Thumbnail side container should be displayed at startup or not

[Albert Astals Cid]

> On mar. 16, 2015, 11:05 p.m., Albert Astals Cid wrote:
> > Can you write an auto test for this?
> > 
> > This sidebar thing breaks a lot, having it auto tested would be great.
> > 
> > See the tests/ folder.
> 
> Albert Astals Cid wrote:
>     ping?
> 
> Pulkit Gupta wrote:
>     Hi sir, 
>     I tried creating auto tests by seeing tests folder, but it was difficult to understand, so I was unable to create auto tests, but I had tested this manually for all the cases, and it was working perfectly fine.
> 
> Albert Astals Cid wrote:
>     I know you can check i is working now, but we need tests to make sure it will always work and if it doesn't it will complain. Please tell me what you did not understand when creating a test and let's try to make you understand it.
> 
> Pulkit Gupta wrote:
>     Hi,
>     I am sorry, but right now I am working on GSoC project, so I won't be able to find time for creating the tests. But once the GSoC ends (approx within 2 weeks), I will again start working on the tests from September itself.

Ping #2


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122787/#review77595
-----------------------------------------------------------


On mar. 3, 2015, 12:20 p.m., Pulkit Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122787/
> -----------------------------------------------------------
> 
> (Updated mar. 3, 2015, 12:20 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 344599
>     http://bugs.kde.org/show_bug.cgi?id=344599
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Previously, thumbnails side container was opened by default at start up. Now Okular will save in settings that when last session was closed, was side container being displayed or not. And will display or hide the side container at next session accordingly.
> 
> 
> Diffs
> -----
> 
>   conf/okular.kcfg f980989 
>   part.cpp 36438af 
>   ui/sidebar.cpp 0c722a9 
> 
> Diff: https://git.reviewboard.kde.org/r/122787/diff/
> 
> 
> Testing
> -------
> 
> Tested that
> ==>when Side container is open, at next start, Side container will open
> ==>If user closes Side container, at next start, Side container will remain closed
> 
> 
> Thanks,
> 
> Pulkit Gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151028/f9a6db92/attachment-0001.html>