[Okular-devel] Review Request 125742: Fix okularplugin linking on VS 2015.

[Gleb Popov]

> On Oct. 22, 2015, 1:18 a.m., Albert Astals Cid wrote:
> > "Fix this by tricking VS that we are building okularcore target."
> > 
> > But then the diff says "okularpart_EXPORTS"?

Oops, my bad. The class is declared with OKULARPART_EXPORT, so the definition being added is right, it's patch description is wrong. Fixed.


- Gleb


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125742/#review87232
-----------------------------------------------------------


On Oct. 22, 2015, 9:01 a.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125742/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 9:01 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> okularplugin target from mobile/components suffers from the same problem as okularpart in https://git.reviewboard.kde.org/r/125741/ 
> But the cause is a bit different now. okularplugin uses settings.cpp generated by KConfig and its header declares Settings class with OKULARPART_EXPORT. For okularplugin target this macro gets expanded to __declspec(dllimport) and it makes linker to look for Settings class symbols in okularcore.
> 
> Fix this by tricking VS that we are building okularpart target.
> 
> 
> Diffs
> -----
> 
>   mobile/components/CMakeLists.txt a5db04e8e40631452adfee3ed41083724356c6c5 
> 
> Diff: https://git.reviewboard.kde.org/r/125742/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151022/4476ef73/attachment.html>