[Okular-devel] Review Request 125741: okular: Fix linking with MSVC 2015.

[Gleb Popov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125741/
-----------------------------------------------------------

Review request for Okular.


Repository: okular


Description
-------

okular/part.cpp includes interfaces/viewerinterface.h and its OKULARCORE_EXPORT macro gets expanded into __declspec(dllimport). This makes VS linker to drop ViewerInterface::~ViewerInterface() definition and to look for it in KF5OkularCore.dll. But this include is never used anywhere in okularcore, hence missing symbol.

Including interfaces/viewerinterface.h in any of okularcore sources fixes the problem.


Diffs
-----

  core/document.cpp 49ce0650b4f970290490beb0db6d5c29c13311fa 

Diff: https://git.reviewboard.kde.org/r/125741/diff/


Testing
-------


Thanks,

Gleb Popov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151021/b4906bae/attachment.html>