[Okular-devel] Review Request 125683: Port away from KFileDialog.

Gleb Popov 6yearold at gmail.com
Mon Oct 19 07:15:57 UTC 2015



> On Oct. 18, 2015, 11:10 p.m., Albert Astals Cid wrote:
> > shell/shell.cpp, line 405
> > <https://git.reviewboard.kde.org/r/125683/diff/1/?file=411517#file411517line405>
> >
> >     Are the formats for these two calls the same?

Judging from this, i think yes.

![Image description](http://arrowd.name/okular.png)


- Gleb


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125683/#review87030
-----------------------------------------------------------


On Oct. 18, 2015, 11:01 a.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125683/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2015, 11:01 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Make Okular use QFileDialog from Qt5 instead of KFileDialog, which doesn't seem to be present in KF5.
> 
> 
> Diffs
> -----
> 
>   shell/shell.cpp d0204f9dddcbcf47b945ad71027084e0595334db 
> 
> Diff: https://git.reviewboard.kde.org/r/125683/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151019/30724c17/attachment.html>


More information about the Okular-devel mailing list