[Okular-devel] Review Request 125683: Port away from KFileDialog.

Gleb Popov 6yearold at gmail.com
Sun Oct 18 11:11:28 UTC 2015



> On Oct. 18, 2015, 12:11 p.m., Albert Astals Cid wrote:
> > I'm not going to close this since it may make sense to do the change, but you should really check your kdelibs4support installation since it's the second time you open a review request about a header you say it does not exist and it does exist.

Yup, i already found that the problem was on my side, sorry for that. But using QFileDialog wouldn't harm, i hope?


- Gleb


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125683/#review87001
-----------------------------------------------------------


On Oct. 18, 2015, 11:01 a.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125683/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2015, 11:01 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Make Okular use QFileDialog from Qt5 instead of KFileDialog, which doesn't seem to be present in KF5.
> 
> 
> Diffs
> -----
> 
>   shell/shell.cpp d0204f9dddcbcf47b945ad71027084e0595334db 
> 
> Diff: https://git.reviewboard.kde.org/r/125683/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151018/f362501d/attachment-0001.html>


More information about the Okular-devel mailing list