[Okular-devel] Review Request 125623: This patch fix the searching of root items in the table of content treeview

[Albert Astals Cid]

> On oct. 13, 2015, 3:50 p.m., Albert Astals Cid wrote:
> > Hmmm, you sure this is needed? I thought i had fixed this problem with commit 5b62bc71d4b30b8d780dcc998fb78657081bf928
> > 
> > Which file are you using that doesn't work with current master and needs this patch?
> 
> Saheb Preet Singh wrote:
>     I am sorry for this, I didn't noticed. Actually I fixed it some time back and forgot to put on reviewboard.

Can you confirm it works without the patch?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125623/#review86812
-----------------------------------------------------------


On oct. 13, 2015, 3:30 p.m., Saheb Preet Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125623/
> -----------------------------------------------------------
> 
> (Updated oct. 13, 2015, 3:30 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 350366
>     http://bugs.kde.org/show_bug.cgi?id=350366
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> This patch fix the searching of root items in the ktreeviewsearchline. Hence, filtering root items in table of content, reviews, bookmarks section.
> 
> 
> Diffs
> -----
> 
>   ui/ktreeviewsearchline.cpp 4a987ec 
> 
> Diff: https://git.reviewboard.kde.org/r/125623/diff/
> 
> 
> Testing
> -------
> 
> Manually tested for some files.
> 
> 
> Thanks,
> 
> Saheb Preet Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151013/1bc3b966/attachment-0001.html>