[Okular-devel] Review Request 125500: [okular] epub: Add "file" scheme for resourceUrl

[Boris Egorov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125500/
-----------------------------------------------------------

Review request for Okular and Albert Astals Cid.


Repository: okular


Description
-------

Since Qt 5.0, QUrl::toLocalFile() returns empty path for URLs where the
scheme is not "file"[1].

You can see how it fails if you open some epub with images. For example,
http://www.gutenberg.org/ebooks/50080, "EPUB (with images)". There will
be lots of warnings like this:

libepub (II):   OEBPS/ - No such file

And no images will be loaded. This patch fixes a problem by adding a
scheme "file".

    1: http://doc.qt.io/qt-4.8/qurl.html#toLocalFile


Diffs
-----

  generators/epub/epubdocument.cpp 3b0ef56 

Diff: https://git.reviewboard.kde.org/r/125500/diff/


Testing
-------

Open metioned file with patch applied. There is no warnings and images loaded successfully.


Thanks,

Boris Egorov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151003/94a71eb6/attachment.html>