[Okular-devel] Review Request 126193: Port to new JSON plugin loading system

[Alex Richardson]

> On Nov. 29, 2015, 5:49 p.m., Albert Astals Cid wrote:
> > there's a few qdebugs in the code, please remove them

I've removed them locally, any other issues?


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126193/#review88927
-----------------------------------------------------------


On Nov. 28, 2015, 7:28 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126193/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2015, 7:28 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Two commits:
> 
> ---
> 
> Port to new JSON plugin loading system
> 
> This means Okular can now work without ksycoca and KDELibs4Support.
> 
> ---
> 
> Bring back the about backend dialog
> 
> 
> Diffs
> -----
> 
>   generators/plucker/libokularGenerator_plucker.desktop 24756b323ffea2d8c2d0a478f545a00af5be8eda 
>   ui/fileprinterpreview.cpp 47035d63e2d46118eb5247a42d0ccdfacbb79767 
>   part.cpp d8f1750f33a903c1734857042b601b52d8d8e1f2 
>   generators/poppler/CMakeLists.txt 875a5cd583beb7f5457d74b153f5e942b33e4918 
>   generators/poppler/generator_pdf.cpp a65487af06a221cf7faf72e108aa1f04e1b91b04 
>   generators/poppler/libokularGenerator_poppler.desktop 7b7c778380742f55bcc584d9576ff93d2acb5a9f 
>   generators/poppler/libokularGenerator_poppler.json PRE-CREATION 
>   generators/poppler/okularPoppler.desktop a1ef1d8aa270e3b543fdb35e776b48abc7e05de8 
>   generators/spectre/CMakeLists.txt 617047a7c480096e05c329e421283450712b8bef 
>   generators/spectre/generator_ghostview.cpp b84e1e4e9d3d05d065b3e4e0ebd5fabbf6343c3e 
>   generators/spectre/libokularGenerator_ghostview.desktop 552459d07928a0397b2b5d7f21ea510241ae3ff0 
>   generators/spectre/libokularGenerator_ghostview.json PRE-CREATION 
>   generators/txt/libokularGenerator_txt.desktop df6b0623aee49a644a490827cd755bac1e3a39ca 
>   generators/mobipocket/okularMobi.desktop 5a50a33d4c709a26703c9b24be033bdb3ab0419f 
>   generators/ooo/CMakeLists.txt 5d11daf24cb6e4c04448be856877130e72052f10 
>   generators/ooo/generator_ooo.cpp 078173060c9805f876acad5716669c9a76373740 
>   generators/ooo/libokularGenerator_ooo.desktop d769da3d8c94c7035c31cf1469792c82064baede 
>   generators/ooo/okularOoo.desktop f319c8c7aad44ede0228c12461c009184ff77bfc 
>   generators/ooo/libokularGenerator_ooo.json PRE-CREATION 
>   generators/plucker/CMakeLists.txt c37646764818e9147516c696a7320c427636f6f6 
>   generators/plucker/generator_plucker.cpp 3a91ae7c2dceef0e168c6d3856876b8ae2d5c6d1 
>   generators/plucker/libokularGenerator_plucker.json PRE-CREATION 
>   generators/plucker/okularPlucker.desktop 17c5704d2c34eddf7be27d3e81a9c115fa5377df 
>   generators/spectre/okularGhostview.desktop d5bd725d3e0fbad2517f13e83499764000adf1e9 
>   generators/tiff/CMakeLists.txt bab056f16a097e804b9ec8dfda295d4a745bd5b9 
>   generators/tiff/generator_tiff.cpp 31b2e3e09322196c3a36698ebf457b224a34d90f 
>   generators/tiff/libokularGenerator_tiff.desktop 8ca968f655a4b42090e1944354b6981788319854 
>   generators/tiff/libokularGenerator_tiff.json PRE-CREATION 
>   generators/tiff/okularTiff.desktop cfc2b3943fc2c5bb93fac3c26ed75267234135ae 
>   generators/txt/generator_txt.cpp 8c3d2f60ebf12accd87ebfe1630d74e2dfd484ee 
>   generators/txt/CMakeLists.txt faae13a479bb80e507ed8e657ff66d51e391666f 
>   generators/txt/libokularGenerator_txt.json PRE-CREATION 
>   generators/txt/okularTxt.desktop e9dda9f695c474c9176a8b32b3bffcc1519222ac 
>   generators/xps/CMakeLists.txt 6bd8e58488d929ffc6f8a0cd16ef8fd2fa238587 
>   generators/xps/generator_xps.cpp d86dbcb6e0f86f582208cc4110b4980ee28e8c66 
>   generators/xps/libokularGenerator_xps.desktop 173ba72ffe47a4834c5e125b32b969a4c6fac2d3 
>   generators/xps/libokularGenerator_xps.json PRE-CREATION 
>   generators/xps/okularXps.desktop 2e5a2c47cb50180edd22d2ec8b910d8708b854c2 
>   CMakeLists.txt d0b180e08085c58100c84a259de7528159c8a532 
>   core/document.h 63f58741bd6680a673945a7b7c05a10130968beb 
>   generators/mobipocket/libokularGenerator_mobi.json PRE-CREATION 
>   generators/mobipocket/libokularGenerator_mobi.desktop 13a13600e976a2d617d7fb83f03ddeee4d91b738 
>   generators/mobipocket/generator_mobi.cpp 3040745d1b2595d005a543d0cd2c9ecde8d53902 
>   generators/mobipocket/CMakeLists.txt 910623b68ebcf60a07ebaad6d6fd554b816934f5 
>   generators/kimgio/okularKimgio.desktop 983c300cb2ad019c9c98b74d896ae28fb01def2a 
>   generators/kimgio/libokularGenerator_kimgio.json PRE-CREATION 
>   generators/kimgio/libokularGenerator_kimgio.desktop ea483428613943fb3bc0e0535280d4e98c196b68 
>   generators/kimgio/generator_kimgio.cpp 5dc9011e454e66965062baf0453bae7c6822d047 
>   generators/kimgio/CMakeLists.txt 5c46af8001826c7b66d8dda273a94f9c260f2d7c 
>   generators/fictionbook/okularFb.desktop 998b22486837578c409c7ed7a3534480348415c4 
>   generators/fictionbook/libokularGenerator_fb.json PRE-CREATION 
>   generators/fictionbook/libokularGenerator_fb.desktop ee51e8f0003dc1182684353eb79f8f2de69206b8 
>   generators/fictionbook/generator_fb.cpp 34fcd0536dd259f64eaf95bcd0c5082bcac426ad 
>   generators/fictionbook/CMakeLists.txt 108568b6decdf804ba579a6dc8c81ad01a006214 
>   generators/fax/okularFax.desktop 8b86b91ed02b6e15547686e2f9a589f80516ce84 
>   generators/fax/libokularGenerator_fax.json PRE-CREATION 
>   generators/fax/libokularGenerator_fax.desktop fcffa707b157a91f84a43a8c6e8ac5b93363fef9 
>   generators/fax/generator_fax.cpp 078f18cb103e6c6bc6c59aa490227b67f0d2445c 
>   generators/fax/CMakeLists.txt f3a321c9039163558c91f1b417be2ca6ed7695d0 
>   generators/epub/okularEPub.desktop 2da8c9097f1764aaee675a183b4d4eb4586d44b1 
>   generators/epub/libokularGenerator_epub.json PRE-CREATION 
>   generators/epub/libokularGenerator_epub.desktop 14d64159fd2e51ce91de3abde3cb0380c9ffe0c8 
>   generators/epub/generator_epub.cpp 48e73148940bfb62b5e371366de31c9b8d961d4c 
>   generators/epub/CMakeLists.txt fa989ad88a04f3f403eb5eb51ba6faff4cb992a2 
>   generators/dvi/okularDvi.desktop 5c7d3a96021a887171a6d98f0693ad88bc967f29 
>   generators/dvi/libokularGenerator_dvi.json PRE-CREATION 
>   generators/dvi/libokularGenerator_dvi.desktop 39edcfadf8fb0273c7b7f1bde2912566db605c61 
>   generators/dvi/generator_dvi.cpp d1536cc038e5d957cd1ad1d3e18d2578511db929 
>   generators/dvi/CMakeLists.txt e95c9ca09b469db6c33be78dd332f27f0ec1bbd5 
>   generators/djvu/okularDjvu.desktop 1c2fd43b63f071f9d726e1a605681d32bc93d25f 
>   generators/djvu/libokularGenerator_djvu.json PRE-CREATION 
>   generators/djvu/libokularGenerator_djvu.desktop 887377998ce55802cd505c42e359919cb814d615 
>   generators/djvu/generator_djvu.cpp b01175983b7f34391d4e5b2765e50340cb52722b 
>   generators/djvu/CMakeLists.txt 8ca545c5a43d71108b08521d625d1b76facd69da 
>   generators/comicbook/okularComicbook.desktop 1dded78f4245d2770f1431f7e02123c2fa681ac9 
>   generators/comicbook/libokularGenerator_comicbook.json PRE-CREATION 
>   generators/comicbook/libokularGenerator_comicbook.desktop 5a91a5fdd053819d75d28f93de152b9c904f41ff 
>   generators/comicbook/generator_comicbook.cpp a0d03fad112b3f251ddf6a0cc7408134b36a2988 
>   generators/comicbook/CMakeLists.txt 4df23a679f27468fc1d06425b8006c0a02e0f202 
>   generators/chm/okularChm.desktop ed42bc25c87ee1fafe1a729d3f14f1c75e5784dd 
>   generators/chm/libokularGenerator_chmlib.json PRE-CREATION 
>   generators/chm/libokularGenerator_chmlib.desktop dc3ac9308fc2447f3b11f96c5618058ca95832fc 
>   core/document.cpp 6953b1fb0dc29a375be7ff331a2a2bccce975366 
>   core/document_p.h fda23275033645ea67f5ad9d27341fc4635ede34 
>   core/generator.h 68a7f1477deb3e44c3ff78e3c909a90082b6b8cd 
>   generators/CMakeLists.txt 99ff78d32a02fc0bdf7fca8092db46f893774ed0 
>   generators/chm/CMakeLists.txt e54affca31ba18e0a0be894897a7c490a0d093c3 
>   generators/chm/generator_chm.cpp fbdcea8e9dbf7a21a72ad6b5c9d2f7724f7c6330 
> 
> Diff: https://git.reviewboard.kde.org/r/126193/diff/
> 
> 
> Testing
> -------
> 
> unit tests still pass, opening files works
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151130/b0b63b5e/attachment.html>