[Okular-devel] Review Request 126158: Set objectName for 'm_name'

Oliver Sander oliver.sander at tu-dresden.de
Fri Nov 27 18:50:41 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126158/
-----------------------------------------------------------

(Updated Nov. 27, 2015, 6:50 p.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Changes
-------

Submitted with commit e5383ea2d6c25f628871a7af68022e95b62e8550 by Albert Astals Cid on behalf of Oliver Sander to branch frameworks.


Repository: okular


Description
-------

The unit test 'editdrawingtooldialogtest' on the frameworks branch aborts at run-time.  Reason: it expects the dialog to have a KLineEdit member with object name 'name'.  That KLineEdit does exist in the dialog, but no object name is set for it at all.  This patch explicitly sets the object name to 'name', which makes the editdrawingtooldialogtest pass again.


Diffs
-----

  conf/editdrawingtooldialog.cpp bcd65e1 

Diff: https://git.reviewboard.kde.org/r/126158/diff/


Testing
-------


Thanks,

Oliver Sander

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151127/e98f8e17/attachment.html>


More information about the Okular-devel mailing list