[Okular-devel] Review Request 126158: Set objectName for 'm_name'

[Albert Astals Cid]

> On nov. 24, 2015, 10:52 p.m., Albert Astals Cid wrote:
> > > Reason: it expects the dialog to have a KLineEdit member with object name 'name'.
> > 
> > Who does expect that?
> 
> Oliver Sander wrote:
>     The unit test 'editdrawingtooldialogtest', originally written by Laurent Montel, committed by Tobias König in 81f80ac3a4c7211fb0a8cd89dc8da27f6e47780e .
>     
>     If setting the object name is not the correct fix please give me a few hints on what the correct fix really is, and I'll try to update my patch.

I can't find that test you say on https://github.com/KDE/okular/tree/frameworks/autotests

Maybe someone fucked up with the merging in the frameworks branch?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126158/#review88777
-----------------------------------------------------------


On nov. 24, 2015, 7:39 p.m., Oliver Sander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126158/
> -----------------------------------------------------------
> 
> (Updated nov. 24, 2015, 7:39 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> The unit test 'editdrawingtooldialogtest' on the frameworks branch aborts at run-time.  Reason: it expects the dialog to have a KLineEdit member with object name 'name'.  That KLineEdit does exist in the dialog, but no object name is set for it at all.  This patch explicitly sets the object name to 'name', which makes the editdrawingtooldialogtest pass again.
> 
> 
> Diffs
> -----
> 
>   conf/editdrawingtooldialog.cpp bcd65e1 
> 
> Diff: https://git.reviewboard.kde.org/r/126158/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151125/edf39b40/attachment.html>