[Okular-devel] Review Request 126050: Make presentation widget tool bar height independent of screen dpi

[Oliver Sander]

> On Nov. 14, 2015, 4:06 nachm., Albert Astals Cid wrote:
> > I think it should just be the height of  m_pagesEdit plus a few pixels.
> > 
> > Otherwise you may end up in a situation in which it doesn't fit or on which it is too small inside a big bar, what do you think?

Sounds good, a new patch has been uploaded.

Note that this makes the toolbar height resolution-dependent again, because the height of a KLineEdit changes with the screen resolution.  However I suppose that that is a separate bug.


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126050/#review88354
-----------------------------------------------------------


On Nov. 14, 2015, 10:10 nachm., Oliver Sander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126050/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2015, 10:10 nachm.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Currently, the tool bar of the presentation widget has its height hard-coded to 42 pixels.  Consequently, the bar gets thinner and thinner as the screen resolution increases.  This patch sets the height to a fixed fraction (5%) of the screen height instead.
> 
> 
> Diffs
> -----
> 
>   ui/presentationwidget.cpp d8895e5 
> 
> Diff: https://git.reviewboard.kde.org/r/126050/diff/
> 
> 
> Testing
> -------
> 
> Tested by changing the resolution of my display.  With the patch, the tool bar has the same height no matter what the resolution is.
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151114/b40d251d/attachment.html>