[Okular-devel] Review Request 125890: Fix crash on close

[Albert Astals Cid]

> On nov. 2, 2015, 9:52 p.m., Albert Astals Cid wrote:
> > I'd prefer to know who decides to set a tab of -1 since this doesn't seem to be needed in the non frameworks branch seems like the code is "breaking" somewhere else
> 
> David Rosca wrote:
>     QTabWidget::currentChanged probably because the tab widget (KPart widget) is destroyed before QTabWidget. 
>     
>     delete m_tabWidget in Shell destructor works too.
> 
> Albert Astals Cid wrote:
>     That works for me.

I mean i prefer the delete, sorry if was unclear.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125890/#review87890
-----------------------------------------------------------


On oct. 31, 2015, 11:52 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125890/
> -----------------------------------------------------------
> 
> (Updated oct. 31, 2015, 11:52 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Don't try to set invalid (-1) active tab.
> Add the same check also in removeTab.
> 
> 
> Diffs
> -----
> 
>   shell/shell.cpp ce5e76c 
> 
> Diff: https://git.reviewboard.kde.org/r/125890/diff/
> 
> 
> Testing
> -------
> 
> No longer crashes.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151103/143db865/attachment.html>