[Okular-devel] Review Request 123680: Fix embed mode detection

[Jonathan Doman]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123680/
-----------------------------------------------------------

(Updated May 13, 2015, 10:59 p.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Changes
-------

Submitted with commit 223092aa0e1fd5fd1b48a34702d2102fdb1acccf by Albert Astals Cid on behalf of Jonathan Doman to branch Applications/15.04.


Repository: okular


Description
-------

Wow, I have no idea how this happened. I wrote an big test case and spent a lot of time playing with tabs. Stephan Binner even told me about this a month ago, but I didn't quite understand the problem...

Broken embed mode detection means that the tabbed interface is disabled. It actually made it into release... ugh


Diffs
-----

  core/script/kjs_document.cpp 4422953b0e157a9b0554a949969aaf9b13f44974 
  part.cpp 5b03e56e194bf84a9f02ceaf94cad13526715157 

Diff: https://git.reviewboard.kde.org/r/123680/diff/


Testing
-------

Tabs work again.


Thanks,

Jonathan Doman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150513/a23ba5a3/attachment.html>