[Okular-devel] Review Request 123249: Fixing the KActivities integration (Frameworks branch)

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123249/#review79821
-----------------------------------------------------------


Can you please remind me again what this kactivities code exactly does and what's the benefit for the end user?

- Albert Astals Cid


On abr. 3, 2015, 8:39 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123249/
> -----------------------------------------------------------
> 
> (Updated abr. 3, 2015, 8:39 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Since the a3fb02b881d commit, the KF5::Activities are a required dependency (CMakeLists.txt:31).
> 
> Still, the actual code uses ifdefs for KActivities_FOUND macro which no longer exists. This patch removes the macros and restores the feature.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 0a0f546 
>   shell/CMakeLists.txt ec36582 
>   shell/shell.h f345cf3 
>   shell/shell.cpp 6bb89c5 
> 
> Diff: https://git.reviewboard.kde.org/r/123249/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150503/adb18b1f/attachment.html>