[Okular-devel] Review Request 123176: Fix include and library information of OkularConfig.cmake.
Andreas Cord-Landwehr
cordlandwehr at kde.org
Tue Mar 31 16:23:02 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123176/
-----------------------------------------------------------
(Updated March 31, 2015, 4:23 p.m.)
Status
------
This change has been marked as submitted.
Review request for Okular.
Changes
-------
Submitted with commit 9e603cc9239fc26879cb7a95548572aa35162f53 by Andreas Cord-Landwehr to branch frameworks.
Repository: okular
Description
-------
This fixes two issues:
1. ${_okularBaseDir} provides a path to <somedir>/lib which prevents the include dir to be found
2. the find_library search does not consider the architecture prefixes (here I am unsure if I fixed it correctly or if NO_DEFAULT_PATH had a deeper meaning)
Diffs
-----
OkularConfig.cmake 59537c6
Diff: https://git.reviewboard.kde.org/r/123176/diff/
Testing
-------
Manual testing.
Thanks,
Andreas Cord-Landwehr
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150331/cf5481e9/attachment-0001.html>
More information about the Okular-devel
mailing list