[Okular-devel] Review Request 123085: Use descriptive KGuiItem labels for buttons in calls to KMessageBox

[sahil sehgal]

> On March 30, 2015, 7:48 p.m., Albert Astals Cid wrote:
> > ui/searchlineedit.cpp, line 258
> > <https://git.reviewboard.kde.org/r/123085/diff/1/?file=355933#file355933line258>
> >
> >     Why is "Continue from beginning" a better answer than "Yes" to the question "Continue from beginning?"

Yes you are right "Yes" is a better answer.


- sahil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123085/#review78250
-----------------------------------------------------------


On March 20, 2015, 5:46 p.m., sahil sehgal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123085/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 5:46 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 309739
>     http://bugs.kde.org/show_bug.cgi?id=309739
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Earlier the KmessageBox dialog box contained yes, no or continue buttons without any description. But now there is description like "Continue searching" etc in the boxes.
> 
> 
> Diffs
> -----
> 
>   part.cpp 36438af 
>   ui/searchlineedit.cpp 2add7fa 
> 
> Diff: https://git.reviewboard.kde.org/r/123085/diff/
> 
> 
> Testing
> -------
> 
> Executed successfully on the dialog boxes.
> 
> 
> Thanks,
> 
> sahil sehgal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150331/67a1a336/attachment.html>