[Okular-devel] Review Request 122752: Fixed change in mouse cursor appearance (when selected Selection tool)

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122752/#review76809
-----------------------------------------------------------



ui/pageview.cpp
<https://git.reviewboard.kde.org/r/122752/#comment52871>

    This is bad, having a case in a swtich and then a if with the same condition is confusing, you wanto to reorder the case, and then add a comment saying specifically we're falling through to the next case (i.e. not breaking)


- Albert Astals Cid


On feb. 28, 2015, 10:47 a.m., Pulkit Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122752/
> -----------------------------------------------------------
> 
> (Updated feb. 28, 2015, 10:47 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 334798
>     http://bugs.kde.org/show_bug.cgi?id=334798
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Solved the bug where mouse cursor appearance was not changing (when selected Selection Tool) when hovering over certain areas in okular.
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 2dd8cf1 
> 
> Diff: https://git.reviewboard.kde.org/r/122752/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pulkit Gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150301/74e2b068/attachment.html>