[Okular-devel] Review Request 123909: Added import/export of bookmarks as requested in Bug 336381 - easily transfer bookmarks between computers

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123909/#review82625
-----------------------------------------------------------



part.cpp (line 2165)
<https://git.reviewboard.kde.org/r/123909/#comment56975>

    Please clean up all the wrong spacing (marked as red)



part.cpp (line 2184)
<https://git.reviewboard.kde.org/r/123909/#comment56978>

    Please set a fixed versioning for writing and reading out of the data stream. See the "Versioning" part of QDataStream documentation



part.cpp (line 2192)
<https://git.reviewboard.kde.org/r/123909/#comment56977>

    can you please mark these vars as const, makes it a bit easier to read the code if you know we're not going to change them.



part.cpp (line 2230)
<https://git.reviewboard.kde.org/r/123909/#comment56976>

    Have you checked what happens if the documentViewport doesn't exist? i.e. it's a page number bigger than the page coutn?



part.rc (line 2)
<https://git.reviewboard.kde.org/r/123909/#comment56974>

    Need to increase the version


- Albert Astals Cid


On mai. 26, 2015, 7:29 p.m., Nikola Nikolic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123909/
> -----------------------------------------------------------
> 
> (Updated mai. 26, 2015, 7:29 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 336381
>     http://bugs.kde.org/show_bug.cgi?id=336381
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Added import/export functionality with similar workflow as in File->Export As...
> Bookmarks ( only viewports and titles ) are saved in binary file with .okularbm extension.
> Import/Export is available only for currently opened document.
> I haven't used any document identification, because document name and size can change.
> 
> 
> Diffs
> -----
> 
>   part.h 9eebdb2 
>   part.cpp d461ebe 
>   part.rc 60f86e5 
> 
> Diff: https://git.reviewboard.kde.org/r/123909/diff/
> 
> 
> Testing
> -------
> 
> Tested both functionalities, it seems they work.
> This is only an idea how import/export may be implemened, any suggestions for improvement are welcome.
> P.S. Any ideas on how to identify a document properly, so I can implement Import All/Export All functionalities?
> 
> 
> Thanks,
> 
> Nikola Nikolic
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150718/dc39f8cc/attachment-0001.html>