[Okular-devel] Review Request 122074: Fix crash when arguments().mimeType() is an invalid mimetype name.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122074/
-----------------------------------------------------------

(Updated Jan. 16, 2015, 6:22 p.m.)


Status
------

This change has been marked as submitted.


Review request for Okular and Albert Astals Cid.


Repository: okular


Description
-------

I have a JIRA bug report with a PDF attached, and mid-clicking the PDF
in konqueror leads to opening an okularpart with mimetype="application/x-octet-stream"
(the x- in there is very unusual, and unknown to shared-mime-info).
Fixed with null pointer checks.


Diffs
-----

  part.cpp 263f3ad0bd0945590463092df4efdcb9b9515e90 

Diff: https://git.reviewboard.kde.org/r/122074/diff/


Testing
-------

crashes without the patch, works with the patch.


Do I need to manually apply this to master or frameworks, or do you merge regularly?


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150116/b282d6e1/attachment.html>