[Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.

[Albert Astals Cid]

> On des. 14, 2014, 8:58 p.m., Albert Astals Cid wrote:
> > This looks pretty solid now :)
> > 
> > Two minor things:
> >  * You should add it to the manual, i.e. add something to doc/index.docbook
> >  * I'm not convinced of it's position on the menus. At the moment it's close to other "fit" things, but those are permanent, while this is an instant action and it works over the window size and not over the zoom value like the others. I'm undecided about two options: A) Don't show it on the menus at all and give it a shortcut so people can use it (Since i think this is a pretty "advanced/notcommon" option) B) Put it at the end of the View menu in it's own "group" (i.e. with a separator). What do you think?
> 
> Saheb Preet Singh wrote:
>     Before deciding its position on menus I have a doubt. I reviewed the bug description and found this
>     
>     'Zoom in "fit window to page" mode causes the whole window to magnify or shrink accordingly.'
>     
>     Should I work on implementing the movement of window on zoom in and zoom out ?
> 
> Albert Astals Cid wrote:
>     I honestly think that it's not needed.
> 
> Saheb Preet Singh wrote:
>     i think keeping it as a shortcut would be a good idea
> 
> Albert Astals Cid wrote:
>     Now we need to think of a default shortcut. Any suggestion?
> 
> Saheb Preet Singh wrote:
>     ctrl + E or ctrl + shift + F
> 
> Albert Astals Cid wrote:
>     ctrl + shift + F is obviously out of question since it's already used
>     
>     What's the rationale behind Ctrl+E?
> 
> Saheb Preet Singh wrote:
>     oh I am sorry for suggesting ctrl + shift + F. We can use something like ctrl + alt + F.
>     
>     I suggested ctrl + E as it is already being used in gimp for shrink wrap.
> 
> Albert Astals Cid wrote:
>     Hmmm, my gimp uses Ctrl+J ? Which gimp version do you use?
> 
> Saheb Preet Singh wrote:
>     oops sorry, it works with ctrl + j only. So can we use ctrl + j ?

Ctrl+J seems good, can you make it the patch before this wednesday that is the Feature Freeze for the next release? If not please tell and i'll try to find time to do it myself.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115283/#review72005
-----------------------------------------------------------


On nov. 25, 2014, 7:17 a.m., Saheb Preet Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115283/
> -----------------------------------------------------------
> 
> (Updated nov. 25, 2014, 7:17 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 326844
>     http://bugs.kde.org/show_bug.cgi?id=326844
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> okular do not have a feature to resize the current window to the current page size.
> 
> The bug is solved upto some extent, the window is resizing as desired.
> 
> resize method of qwidget class is used to resize the window.
> 
> The window is resizing  as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again.  Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again.
> 
> I think the problem occurs due to something happening in the other portion of the code.
> 
> I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:-
> 
> ==> Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window.
> 
> ==> Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ).
> 
> The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648
> 
> Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented.
> 
> 
> Diffs
> -----
> 
>   shell/shell.cpp f7675fd 
>   ui/pageview.h a8adb2c 
>   ui/pageview.cpp 17e66f4 
>   ui/sidebar.h cf5dfc6 
>   ui/sidebar.cpp 0c722a9 
>   part.h 594eb44 
>   part.cpp 50a1b20 
>   part.rc 60f86e5 
>   shell/shell.h 224acfe 
> 
> Diff: https://git.reviewboard.kde.org/r/115283/diff/
> 
> 
> Testing
> -------
> 
> 
> tested when
> ==> window is maximized and restored.
> ==> thumbnails, table of content are opened and closed.
> ==> various toolbars are shown and hidden.
> ==> for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ).
> 
> 
> Thanks,
> 
> Saheb Preet Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150222/93409263/attachment-0001.html>