[Okular-devel] [okular] [Bug 219121] if holding mouse mid button, perform scroll instead zoom

[Dmitry Osipenko via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=219121

--- Comment #19 from Dmitry Osipenko <digetx at gmail.com> ---
(In reply to Yichao Zhou from comment #16)
> Hi Dmitry,
> 
> I tried to reply to this bug this afternoon by email from my smartphone but
> it seems I did not do it correctly.  Sorry for the confusion.
> 
> The problem about my patch was that the maintainer thought that we should
> use the middle mouse to pan the page (like we do in evince and some 3D
> modelling software) instead of scrolling the page (like we do in
> firefox/adobe reader).  I proposed that I could implement all of the three
> modes (zoom, pan, scroll) and let the user choose them.  It seemed that
> Albert agreed on this.  However because that patch works well on my gentoo
> box and I really do not need to pan feature, I put this task behind my
> schedule.  I realized that this patch does not work on KF5 recently.  But I
> no longer use KDE frequently (maybe I will be back in the future) now so I
> will not work on this in short term. Feel free to implement it if you want
> to see this feature in the upstream! Communication with Albert before
> working is a good idea to make sure that your patch will be merged finally.

Thanks for quick response! Coincidentally, I'm already using panning with
middle button for a quite long time with KF5. However, it's just dumb panning
(which I'm finding more usable) without evince-like scrolling momentum. So, I'm
picking your patch, adapting it for KF5 and adding pan feature.

(In reply to Gregory M. Turner from comment #17)
> Maybe it's to do with the particulars of my box but the patch from this bug
> never quite worked correctly on my Gentoo box, Yichao (although I used it
> for many months and eventually decided to just stop using Okular.
> 
> It /almost/ worked.  But certain actions --  I can't remember /exactly/
> what, but maybe it was something to do with scrolling past a page boundary?
> -- would cause the display to go blank.  Under the hood everything was fine;
> if you used the "normal" scrolling techniques then the document would appear
> again, but it was as though okular did not realize that certain parts of the
> page needed to be repainted.
> 
> Sorry I can't remember more precisely what the exact way to trigger these
> problems were.  But I just wanted to mention it for the record, so that if
> someone is looking into these patches with an eye toward refactoring or
> merging them in some way, they should be mindful that there may  be some bug
> in there.

Thanks, that might be helpful.

(In reply to Albert Astals Cid from comment #18)
> Dmitry https://git.reviewboard.kde.org/r/115335/

In the last review comment you mentioned conversation on Feb 7, that I haven't
found. I guess it was discussion on adding panning feature, right? Or was it
something else, maybe other issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.