[Okular-devel] Review Request 125792: Fix linking with okularpart.dll when using MSVC.

[Gleb Popov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125792/
-----------------------------------------------------------

(Updated Dec. 16, 2015, 12:23 a.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Changes
-------

Submitted with commit 0928298a74087f1a42fc53f5eca35d0315d36c22 by Patrick Spendrin on behalf of Gleb Popov to branch frameworks.


Repository: okular


Description
-------

To link with DLL using Visual Studio linker, it should be fed with .lib file corresponding to .dll being linked. For libraries created with SHARED keyword, CMake figures this out and passes correct file. But for okularpart target, the DLL itself is passed, which leads to error during linking.

This seems to be a bug in CMake and this patch works it around.


Diffs
-----

  CMakeLists.txt 4aea44d 

Diff: https://git.reviewboard.kde.org/r/125792/diff/


Testing
-------


Thanks,

Gleb Popov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151216/78e3bf2c/attachment.html>