[Okular-devel] Review Request 125791: Fix compilation of fax and comicbook generators with MSVC 2015.

[Patrick Spendrin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125791/#review89294
-----------------------------------------------------------



generators/comicbook/CMakeLists.txt (line 19)
<https://git.reviewboard.kde.org/r/125791/#comment61061>

    looks good.



generators/fax/faxexpand.h (line 25)
<https://git.reviewboard.kde.org/r/125791/#comment61060>

    This should read #ifndef Q_OS_WIN
    but I guess this include can be removed for everybody?


- Patrick Spendrin


On Okt. 25, 2015, 2:15 nachm., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125791/
> -----------------------------------------------------------
> 
> (Updated Okt. 25, 2015, 2:15 nachm.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Fix compilation of fax and comicbook generators with MSVC 2015.
> 
> 
> Diffs
> -----
> 
>   generators/comicbook/CMakeLists.txt deed292fd179535dfed129cdb6007b49668bafa9 
>   generators/fax/faxexpand.h f0629746cd82870ff0062e3a0f21a80b23d5f73c 
> 
> Diff: https://git.reviewboard.kde.org/r/125791/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151210/7f8fbd41/attachment.html>