[Okular-devel] Review Request 126255: Okular icon changes

[Albert Astals Cid]

> On des. 6, 2015, 10:30 p.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 560
> > <https://git.reviewboard.kde.org/r/126255/diff/1/?file=421135#file421135line560>
> >
> >     Why is transform move better suited than mouse? moving is not the only thing that mode activates. I agree input-mouse is not great either but using the transform move would make me think that moving is the only thing it does.
> 
> andreas kainz wrote:
>     what else you can do with the browse tool the main thing would be move.
>     
>     the other icons I change cause the look and feel is better that's a stupid idea but using the input-mouse icon is wrong.
>     
>     tell me what you can do with the browse tool and I will find the right icon or make a new one.

It's the tool where link clicking works, where annotation adding/editing works, etc.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126255/#review89194
-----------------------------------------------------------


On des. 6, 2015, 11:43 a.m., andreas kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126255/
> -----------------------------------------------------------
> 
> (Updated des. 6, 2015, 11:43 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> change toolbar icon for browse tool to transform-move
> change sidebar preferences icons:
> - performance to cpu
> - presentation to applications-multimedia
> - annotions to applications-office
> only colored icons were used in the preferences sidebar
> 
> 
> Diffs
> -----
> 
>   conf/preferencesdialog.cpp f0c3f2c 
>   ui/pageview.cpp 3ebf7dc 
> 
> Diff: https://git.reviewboard.kde.org/r/126255/diff/
> 
> 
> Testing
> -------
> 
> work with breeze and oxygen
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151209/5aeffcd7/attachment.html>