[Okular-devel] Review Request 126255: Okular icon changes

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126255/#review89194
-----------------------------------------------------------



conf/preferencesdialog.cpp (line 42)
<https://git.reviewboard.kde.org/r/126255/#comment61026>

    We're already using the cpu icon for the specific cpu subsection of the performance page, i don't think using the cpu icon twice is a good idea.



conf/preferencesdialog.cpp (line 52)
<https://git.reviewboard.kde.org/r/126255/#comment61027>

    Why would you use the applications mutlimedia icon for presentation? I don't think it makes any sense, that icon can be anything the represents the multimedia set of applications. What if that icon had a video player representation?



conf/preferencesdialog.cpp (line 55)
<https://git.reviewboard.kde.org/r/126255/#comment61028>

    Same question as above, why is an icon that represents "office applications as a whole" suited to represent the annotations feature? What if that icon had a spreadsheet?



ui/pageview.cpp (line 560)
<https://git.reviewboard.kde.org/r/126255/#comment61029>

    Why is transform move better suited than mouse? moving is not the only thing that mode activates. I agree input-mouse is not great either but using the transform move would make me think that moving is the only thing it does.


- Albert Astals Cid


On des. 6, 2015, 11:43 a.m., andreas kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126255/
> -----------------------------------------------------------
> 
> (Updated des. 6, 2015, 11:43 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> change toolbar icon for browse tool to transform-move
> change sidebar preferences icons:
> - performance to cpu
> - presentation to applications-multimedia
> - annotions to applications-office
> only colored icons were used in the preferences sidebar
> 
> 
> Diffs
> -----
> 
>   conf/preferencesdialog.cpp f0c3f2c 
>   ui/pageview.cpp 3ebf7dc 
> 
> Diff: https://git.reviewboard.kde.org/r/126255/diff/
> 
> 
> Testing
> -------
> 
> work with breeze and oxygen
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151206/94356807/attachment-0001.html>