[Okular-devel] Review Request 123427: Save view information per file

[Oliver Sander]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123427/#review89186
-----------------------------------------------------------


The part in pageview.cpp:1426 seems overly complicated:  There seems to be no reason to convert the QVariant to 'int' if the method returns QVariant anyway.  Also, the variable 'mode' maybe used uninitialized.  Here is my alternative implementation:

        case ViewModeModality:
        {
            for (int i=0; i < d->aViewMode->menu()->actions().size(); ++i)
            {
                const QAction* action = d->aViewMode->menu()->actions().at(i);
                if ( action->isChecked() )
                    return action->data();
            }
            return QVariant();
        }

Other than that, the patch appears to work nicely.  Thanks!

- Oliver Sander


On Sept. 15, 2015, 6:35 nachm., Felix Mauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123427/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 6:35 nachm.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 341318
>     http://bugs.kde.org/show_bug.cgi?id=341318
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Adds the functiionality to save the view mode (single page, facing...) and continuous scrolling to the document information as it is already done with the zoom information.
> 
> 
> Diffs
> -----
> 
>   core/document.cpp cd9ea6d 
>   core/view.h a369d24 
>   ui/pageview.h 376bbdc 
>   ui/pageview.cpp dc9eab8 
> 
> Diff: https://git.reviewboard.kde.org/r/123427/diff/
> 
> 
> Testing
> -------
> 
> I use a version with this patch applied since a couple of days. The intended functionality seems to work reliably.
> Maybe it would be nice to implement a "standard view" selection in the options dialog as it's done for the zoom mode.
> 
> 
> Thanks,
> 
> Felix Mauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151206/a1ea64c4/attachment.html>