[Okular-devel] Review Request 126214: Allow enqueuing of sound annotations for playback

[Albert Astals Cid]

> On des. 2, 2015, 5:11 p.m., Sumit Sahrawat wrote:
> > Looking at the code, it seems like the 'Stop Sound' option only appears when sound is playing. Which means that there is nothing left to be done before the enqueuing bit.

After reading the code and thinking a bit more about it, I am not sure the enqueuing makes sense. Okular is not a music player in which you're going to create a playlist, if you have a sound you'll want to play it or not, i'd say the use case for "I want to play this but after this finishes" is quite small and not sure we should worry about it.

What do you think?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126214/#review89054
-----------------------------------------------------------


On des. 1, 2015, 12:33 p.m., Sumit Sahrawat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126214/
> -----------------------------------------------------------
> 
> (Updated des. 1, 2015, 12:33 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 326536
>     http://bugs.kde.org/show_bug.cgi?id=326536
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> I understood the bug as asking for a feature to enqueue sounds if sound is currently playing.
> 
> I did not understand why a QHash was being used to manage playbacks, which confused me:
> 
> Q: Does okular support simultaneous playback of multiple sounds?
> 
> If so, I don't think both simultaneous output and enqueuing can be supported in an intuitive way using the right click menu. I've replaced the old QHash with a QQueue, which acts as a playlist of sounds to be played.
> 
> 
> Diffs
> -----
> 
>   core/audioplayer.h b335b5e 
>   core/audioplayer.cpp ab735f3 
>   core/audioplayer_p.h 32fe4de 
>   core/document.cpp 6953b1f 
>   ui/pageview.cpp 3ebf7dc 
>   ui/presentationwidget.cpp e6ecdc5 
> 
> Diff: https://git.reviewboard.kde.org/r/126214/diff/
> 
> 
> Testing
> -------
> 
> No testing done. I couldn't find a document with many sound annotations. I thought I'd create one using Okular, but it doesn't support that yet.
> 
> Albert: What do you use to test this? Can you provide me a link to the same document?
> 
> 
> Thanks,
> 
> Sumit Sahrawat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151202/f3599bc9/attachment.html>