[Okular-devel] Review Request 124716: Create "View/Trim View" submenu to hold "Trim Margins" and add "Trim To Selection"

[Jake Linder]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124716/
-----------------------------------------------------------

(Updated Aug. 23, 2015, 6:37 p.m.)


Review request for Okular and Albert Astals Cid.


Changes
-------

PageView::updateItemSize can (surprisingly) be called before PageView::setupViewerActions() when Print Preview issued. NPE-proof the code.


Bugs: 166642, 340690, 350073, and 351156
    http://bugs.kde.org/show_bug.cgi?id=166642
    http://bugs.kde.org/show_bug.cgi?id=340690
    http://bugs.kde.org/show_bug.cgi?id=350073
    http://bugs.kde.org/show_bug.cgi?id=351156


Repository: okular


Description
-------

Create "View/Trim View" submenu to hold "Trim Margins" and add "Trim To Selection" (351156)


Diffs (updated)
-----

  conf/okular.kcfg 332eafb7da83f778501ef63c4a607f7568ed7713 
  part-viewermode.rc bccd4912fcc11d9f091cbab2b056f3fbf5bf5cf7 
  part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 
  ui/pageview.h e65b57500d12ae2d8c5286e6542504e17813668c 
  ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 

Diff: https://git.reviewboard.kde.org/r/124716/diff/


Testing
-------

# Changes

C1. Added submenu, moved "Trim margins" (TM mode) to it and added  "Trim To Selection" (TS mode).
C2. Activating "Trim To selection" enters a new mousemode, similar to RectSelect for defining a viewport.
C3. Once a viewport has been defined, it serves as a viewport for all pages in the document. 
C4. Left/Right pages are not treated differently.

# Manual Testing

T1. Switching between modes enforces at most one active.
T2. Can deactivate a mode by selecting it again from the menu.
T3. When draggin bbox selection, clicking outside page does not crash.
T4. When in "Facing Pages" mode, mouse release must be over any page (or is ignored).
T5. Normalized bbox coords are computed relative to page indicated by point of mouse release.
T6. Behave as expected when switching between any pair of No Trim/Trim Margins/Trim To Selection.
T7. TM mode persisted across app restarts (existing behavior).
T8. TS mode forgotten across app restarts (as desired).
T9. Exiting and reselectin "Trim To Selection" prompts for new bbox.
T10. Choosing a small Trim bbox enforces minimium dimensions size (As percentag of total), as
it does in TM mode, because of the "scale big and crop down" implementation, to avoid huge pixmaps.
TS mode minimum set at 20% (vs. TM mode's 50%).

# Pending Issues

P2. [HARMLESS] When in TM mode and switching to TS mode, the view jumps out of TM mode for the 
bbox selection interaction.


Thanks,

Jake  Linder

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150823/3c66a463/attachment-0001.html>