[Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode

[Jake Linder]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124723/
-----------------------------------------------------------

(Updated Aug. 19, 2015, 2:28 a.m.)


Review request for Okular and Albert Astals Cid.


Changes
-------

Experiencing infrequent crashing (possibly) because of this. WIP until I can reliably repro and resolve


Bugs: 318078
    http://bugs.kde.org/show_bug.cgi?id=318078


Repository: okular


Description (updated)
-------

Interact with hyperlinks in TextSelect mode (WIP)


Diffs
-----

  ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 

Diff: https://git.reviewboard.kde.org/r/124723/diff/


Testing
-------

- cursor switches to to Hand when hovering over link in TextSelect mode.
- clicking on hyperlink jumps to destination in TextSelect mode.
- text selection & copy still works.
- can text-select "over and across" hyperlink.
- can text-select starting at text and ending selection in middle of hyperlink.
- can text-select starting from hyperlink with click and drag.
- can jump to link while there's an active selection.
- can jump to link while there's an active selection spanning same hyperlink.


Thanks,

Jake  Linder

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150819/e773d518/attachment.html>