[Okular-devel] Review Request 124731: fix kimageio generator with Qt 5.4.0 and 5.4.1

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124731/
-----------------------------------------------------------

(Updated Aug. 16, 2015, 12:28 p.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Repository: okular


Description
-------

Two commits:

---

Ensure KImageIO test always finds the currently built generator

REVIEW: 123895

---

Don't rotate images with Qt 5.4.0 and 5.4.1

There was behaviour change that automatically rotated jpeg images based
on exif metadata that was reverted in 5.4.2.
We now skip rotating with those two version to prevent rotating twice.

Also shared some code so that the #ifdef does not need to be added to
both methods

REVIEW: 123895


Diffs
-----

  generators/kimgio/CMakeLists.txt ab06445593a256ccf4b4a926f1263fbac4e2dd93 
  generators/kimgio/generator_kimgio.h 139c23032f634b13b3efa12d1dd469463358fa2d 
  generators/kimgio/generator_kimgio.cpp 9be961f061107bf0d7a942055237ee33cb353daf 
  generators/kimgio/tests/kimgiotest.cpp f8197241142e868f08365f5430f38bd4e731a759 

Diff: https://git.reviewboard.kde.org/r/124731/diff/


Testing
-------

kimageiotest passes again with qt 5.4.1


Thanks,

Alex Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150816/f4c5a95d/attachment-0001.html>