[Okular-devel] Review Request 124687: Implement drawing quick selection tool for presentation mode

[Albert Astals Cid]

> On ago. 12, 2015, 9:43 p.m., Albert Astals Cid wrote:
> > ui/data/drawingtools.xml, line 11
> > <https://git.reviewboard.kde.org/r/124687/diff/3/?file=393675#file393675line11>
> >
> >     How do we translate this?
> 
> Tobias Koenig wrote:
>     Honestly, I have no idea :( Do you have a suggestion?

Add a new attribute to the xml that says "default=true"
Add something to Messages.sh that extracts the i18n-able texts.
On setTools if default==true you call i18n() on the name
This should work, no?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124687/#review83750
-----------------------------------------------------------


On ago. 13, 2015, 7:18 a.m., Tobias Koenig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124687/
> -----------------------------------------------------------
> 
> (Updated ago. 13, 2015, 7:18 a.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Laurent Montel.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Extend the configuration dialog to allow defining multiple pens,
> that can be used for drawing on pages in presentation mode.
> Replace the pen toggle button in presentation mode top bar with
> a select action, to quickly switch between the various pens.
> 
> FEATURE: 345269
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 27a88ddfec18d9259e669eb2ab7b60ef03e2af75 
>   conf/autotests/CMakeLists.txt PRE-CREATION 
>   conf/autotests/editdrawingtooldialogtest.h PRE-CREATION 
>   conf/autotests/editdrawingtooldialogtest.cpp PRE-CREATION 
>   conf/dlgpresentation.cpp 6c68f1e2e16f72a4723a48e331f161d27d068b00 
>   conf/dlgpresentationbase.ui 78f47f7a8c8e4d74c78b562d7bfd0732f8fa5803 
>   conf/editannottooldialog.h PRE-CREATION 
>   conf/editannottooldialog.cpp PRE-CREATION 
>   conf/editdrawingtooldialog.h PRE-CREATION 
>   conf/editdrawingtooldialog.cpp PRE-CREATION 
>   conf/okular.kcfg 332eafb7da83f778501ef63c4a607f7568ed7713 
>   conf/widgetannottools.h f15aa1c4f02293b45c30c309ceeb78b54b27674f 
>   conf/widgetannottools.cpp 6d05eed8bbd4a6f49f54b406ad98f9a10905b7b7 
>   conf/widgetconfigurationtoolsbase.h PRE-CREATION 
>   conf/widgetconfigurationtoolsbase.cpp PRE-CREATION 
>   conf/widgetdrawingtools.h PRE-CREATION 
>   conf/widgetdrawingtools.cpp PRE-CREATION 
>   part.cpp d461ebefe9533eefdcf918eb153826479e034476 
>   ui/annotationtools.h dc36dc7c08778e427636bb9d0454c27ca59f6877 
>   ui/annotationtools.cpp afc71764fd8f82d67fa7f56ce99cf8f4f8c3a64b 
>   ui/data/CMakeLists.txt 491b9935760d0fa81d46b6007f7f44e5e679156b 
>   ui/data/drawingtools.xml PRE-CREATION 
>   ui/drawingtoolselectaction.h PRE-CREATION 
>   ui/drawingtoolselectaction.cpp PRE-CREATION 
>   ui/presentationwidget.h 81beb6c53b9232b409efc3a1f2bd8fb5575b492b 
>   ui/presentationwidget.cpp 0d9a55dc236a016f6808261bc95f8286f9cfa2ec 
> 
> Diff: https://git.reviewboard.kde.org/r/124687/diff/
> 
> 
> Testing
> -------
> 
> Tested manually with Okular
> 
> 
> Thanks,
> 
> Tobias Koenig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150813/9359ac91/attachment.html>