[Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode

[Jake Linder]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124723/
-----------------------------------------------------------

(Updated Aug. 13, 2015, 11:08 p.m.)


Review request for Okular and Albert Astals Cid.


Changes
-------

Add right-click menu to match Browse mode.

Significant code duplication here (change right menu in one place, other is not affected), 
unless cases are merged and code is sprinkled with multiple conditionals instead.


Bugs: 318078
    http://bugs.kde.org/show_bug.cgi?id=318078


Repository: okular


Description
-------

Interact with hyperlinks in TextSelect mode


Diffs (updated)
-----

  ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 

Diff: https://git.reviewboard.kde.org/r/124723/diff/


Testing
-------

- cursor switches to to Hand when hovering over link in TextSelect mode.
- clicking on hyperlink jumps to destination in TextSelect mode.
- text selection & copy still works.
- can text-select "over and across" hyperlink.
- can text-select starting at text and ending selection in middle of hyperlink.
- can text-select starting from hyperlink with click and drag.
- can jump to link while there's an active selection.
- can jump to link while there's an active selection spanning same hyperlink.


Thanks,

Jake  Linder

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150813/77f36061/attachment.html>