[Okular-devel] Review Request 124651: Implement reading mode functionality.

[Anton Ermolenko]

> On Авг. 11, 2015, 1:52 д.п., Albert Astals Cid wrote:
> > Please update documentation.
> > 
> > I haven't tried it, does it remember the state between restarts? Should it?

I don't know. Currently, I didn't implement the remembering of the state of reading mode. If you think it should remember the the state of reading mode, please, tell me, I will implement it.

What do you mean by 'update documentation'. Update product documentation, or add some comments to code and regenerate doxygen files? Give some clue, please =).


> On Авг. 11, 2015, 1:52 д.п., Albert Astals Cid wrote:
> > part.rc, line 86
> > <https://git.reviewboard.kde.org/r/124651/diff/1/?file=390804#file390804line86>
> >
> >     Hmmm, do we really need a menu option for this? Maybe just a shortcut + documentation entry?

I think yes. Not every user read documentation, but hust scrolling through menu one can see that there is a reading mode available. Just like for fullscreen mode. I will mark it as fixed, if you think that we shouldn't have the menu entry, just reopen, I will removed it.


- Anton


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124651/#review83683
-----------------------------------------------------------


On Авг. 13, 2015, 7:41 д.п., Anton Ermolenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124651/
> -----------------------------------------------------------
> 
> (Updated Авг. 13, 2015, 7:41 д.п.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 325190
>     http://bugs.kde.org/show_bug.cgi?id=325190
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Adds functionality to hide all elements with one action.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 27a88dd 
>   part.h 9eebdb2 
>   part.cpp d461ebe 
>   part.rc 60f86e5 
>   ui/readmodemanager.h PRE-CREATION 
>   ui/readmodemanager.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124651/diff/
> 
> 
> Testing
> -------
> 
> Checked if it properly restores elements which was visible before enabling reading mode and do not makes visible elements which wasn't.
> 
> 
> Thanks,
> 
> Anton Ermolenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150813/cd337ac9/attachment.html>