[Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124612/#review83749
-----------------------------------------------------------



generators/poppler/generator_pdf.cpp (line 221)
<https://git.reviewboard.kde.org/r/124612/#comment57966>

    Dependeing on what we do on poppler-qt and poppler core on null configurations (create a default one or not) we need to check here if it's null or not. I think that it makes sense creating a default, probably  in poppler-core


- Albert Astals Cid


On ago. 11, 2015, 9:51 a.m., Tobias Koenig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124612/
> -----------------------------------------------------------
> 
> (Updated ago. 11, 2015, 9:51 a.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Laurent Montel.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=326230
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=326230
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> The patch adds basic support for RichMedia annotations in PDF files. The Media9 LaTeX package includes a Flash player and the actual video file as embedded files into the PDF. This patch parses the parameters, which are passed to the Flash player, extracts the referenced video file and uses the normal video player for playback.
> 
> Note: This patch requires a poppler version that has the two patches https://bugs.freedesktop.org/show_bug.cgi?id=91547 and https://bugs.freedesktop.org/show_bug.cgi?id=91548 included. Therefor this patch is marked as WIP for the moment.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindPoppler.cmake 6389a625d3ba4de5d12378a920c1576a1b505903 
>   core/annotations.h 4f107440dc824fd9049a30082befd18642e63895 
>   core/annotations.cpp e02994688414bdf485b308d6ef122ee2eff3fbaf 
>   generators/poppler/annots.cpp 8cde64833831ec833b3be552608cff99d38f8e63 
>   generators/poppler/config-okular-poppler.h.cmake 1e8ff9ed34164b1fcd42b504541e38241c59efa4 
>   generators/poppler/generator_pdf.cpp 07abf75c2f530cfa275b797fc9287167df5a4a8c 
>   ui/pageview.cpp 5e7fc29178b364bc91be7ab77f30e6e32ae731f7 
>   ui/presentationwidget.cpp 0d9a55dc236a016f6808261bc95f8286f9cfa2ec 
> 
> Diff: https://git.reviewboard.kde.org/r/124612/diff/
> 
> 
> Testing
> -------
> 
> Tested with the PDF file that is attached to Bug 326230.
> 
> 
> Thanks,
> 
> Tobias Koenig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150812/786ff305/attachment.html>