[Okular-devel] Review Request 124709: Fix play back of video with rendition link

Tobias Koenig tokoe at kde.org
Wed Aug 12 09:18:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124709/
-----------------------------------------------------------

Review request for Okular, Albert Astals Cid and Laurent Montel.


Bugs: 324167
    http://bugs.kde.org/show_bug.cgi?id=324167


Repository: okular


Description
-------

Process the operations of the rendition link independently of whether
there is a JS script or not. Most of the time the JS script won't be
executed correctly anyway, since Okular is missing most of the JS API,
so we should fall back on the given operations.

BUGS: 324167


Diffs
-----

  core/document.cpp 85fe007866e77bc99ac0746a6c53b5c92ab73f67 

Diff: https://git.reviewboard.kde.org/r/124709/diff/


Testing
-------

Tested with the PDF file that is attached to https://bugs.kde.org/show_bug.cgi?id=324167 Clicking on the video annotation on the second and third page, starts it now correctly.


Thanks,

Tobias Koenig

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150812/c580b076/attachment.html>


More information about the Okular-devel mailing list