[Okular-devel] Review Request 124687: Implement drawing quick selection tool for presentation mode

[Tobias Koenig]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124687/
-----------------------------------------------------------

(Updated Aug. 11, 2015, 12:30 p.m.)


Review request for Okular, Albert Astals Cid and Laurent Montel.


Changes
-------

This updated version of the patch introduces the following changes:
   - use proper naming for the new functionality (drawing tool instead of quick selection tool)
   - provide a set of primary colors as default values, not just a single one
   - show all colors as separate buttons in the presentation top bar for faster switching (no need to open the KSelectAction drop down first)
   - show the configured color directly on the buttons in presentation top bar


Repository: okular


Description
-------

Extend the configuration dialog to allow defining multiple pens,
that can be used for drawing on pages in presentation mode.
Replace the pen toggle button in presentation mode top bar with
a select action, to quickly switch between the various pens.

FEATURE: 345269


Diffs (updated)
-----

  CMakeLists.txt 27a88ddfec18d9259e669eb2ab7b60ef03e2af75 
  conf/autotests/CMakeLists.txt PRE-CREATION 
  conf/autotests/editdrawingtooldialogtest.h PRE-CREATION 
  conf/autotests/editdrawingtooldialogtest.cpp PRE-CREATION 
  conf/dlgpresentation.cpp 6c68f1e2e16f72a4723a48e331f161d27d068b00 
  conf/dlgpresentationbase.ui 78f47f7a8c8e4d74c78b562d7bfd0732f8fa5803 
  conf/editannottooldialog.h PRE-CREATION 
  conf/editannottooldialog.cpp PRE-CREATION 
  conf/editdrawingtooldialog.h PRE-CREATION 
  conf/editdrawingtooldialog.cpp PRE-CREATION 
  conf/okular.kcfg 332eafb7da83f778501ef63c4a607f7568ed7713 
  conf/widgetannottools.h f15aa1c4f02293b45c30c309ceeb78b54b27674f 
  conf/widgetannottools.cpp 6d05eed8bbd4a6f49f54b406ad98f9a10905b7b7 
  conf/widgetconfigurationtoolsbase.h PRE-CREATION 
  conf/widgetconfigurationtoolsbase.cpp PRE-CREATION 
  conf/widgetdrawingtools.h PRE-CREATION 
  conf/widgetdrawingtools.cpp PRE-CREATION 
  part.cpp d461ebefe9533eefdcf918eb153826479e034476 
  ui/data/CMakeLists.txt 491b9935760d0fa81d46b6007f7f44e5e679156b 
  ui/data/drawingtools.xml PRE-CREATION 
  ui/drawingtoolselectaction.h PRE-CREATION 
  ui/drawingtoolselectaction.cpp PRE-CREATION 
  ui/presentationwidget.h 81beb6c53b9232b409efc3a1f2bd8fb5575b492b 
  ui/presentationwidget.cpp 0d9a55dc236a016f6808261bc95f8286f9cfa2ec 

Diff: https://git.reviewboard.kde.org/r/124687/diff/


Testing
-------

Tested manually with Okular


Thanks,

Tobias Koenig

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150811/f39f7f2d/attachment.html>