[Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

[Tobias Koenig]

> On Aug. 10, 2015, 9:34 p.m., Albert Astals Cid wrote:
> > core/annotations.cpp, line 2968
> > <https://git.reviewboard.kde.org/r/124612/diff/1/?file=389794#file389794line2968>
> >
> >     This and ::store are doing virtually nothing?

Well, that is the same code the other annotation classes have: SoundAnnotation, MovieAnnotation, ScreenAnnotation...
At least the ::store methods() add a new entry to the DOM tree, so they don't do _nothing_ :)

So do you prefer to remove them from RichMediaAnnotation?


> On Aug. 10, 2015, 9:34 p.m., Albert Astals Cid wrote:
> > core/annotations.cpp, line 3019
> > <https://git.reviewboard.kde.org/r/124612/diff/1/?file=389794#file389794line3019>
> >
> >     Since MovieAnnotation::setMovie doesn't do the delete, i'd do the same.
> >     
> >     OTOH we're deleting it in the destructor so kind of makes sense...
> >     
> >     Feel free to do nothing :D

Did nothing ;)


- Tobias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124612/#review83677
-----------------------------------------------------------


On Aug. 10, 2015, 6:48 a.m., Tobias Koenig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124612/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 6:48 a.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Laurent Montel.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=326230
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=326230
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> The patch adds basic support for RichMedia annotations in PDF files. The Media9 LaTeX package includes a Flash player and the actual video file as embedded files into the PDF. This patch parses the parameters, which are passed to the Flash player, extracts the referenced video file and uses the normal video player for playback.
> 
> Note: This patch requires a poppler version that has the two patches https://bugs.freedesktop.org/show_bug.cgi?id=91547 and https://bugs.freedesktop.org/show_bug.cgi?id=91548 included. Therefor this patch is marked as WIP for the moment.
> 
> 
> Diffs
> -----
> 
>   core/annotations.h bbe2c5c40156f9909d81868aaeca02844e3a294d 
>   core/annotations.cpp ac45a5ad00d626d5a44311708349df27c5bd37f1 
>   generators/poppler/annots.cpp 5aca423fa504d783d93694ba4f35c0c97b9463e6 
>   generators/poppler/generator_pdf.cpp ae8599b8b93b6b798ff09c877d43078f0bb0f68f 
>   ui/pageview.cpp 7cf8adbabcc9289bcce09fa4b3fafc5b39d5edcb 
>   ui/presentationwidget.cpp 257dcb0b6099cb8bb864290512b6708415090a95 
> 
> Diff: https://git.reviewboard.kde.org/r/124612/diff/
> 
> 
> Testing
> -------
> 
> Tested with the PDF file that is attached to Bug 326230.
> 
> 
> Thanks,
> 
> Tobias Koenig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150811/a358b11a/attachment.html>