[Okular-devel] Review Request 123393: FindLibSpectre: Use FindPkgConfig instead of UsePkgConfig

Albert Astals Cid aacid at kde.org
Sat Apr 18 23:09:12 UTC 2015



> On abr. 18, 2015, 11:08 p.m., Albert Astals Cid wrote:
> > Ship It!

Please commit to 15.04 and merge to master.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123393/#review79184
-----------------------------------------------------------


On abr. 18, 2015, 9:53 a.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123393/
> -----------------------------------------------------------
> 
> (Updated abr. 18, 2015, 9:53 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> The latter is deprecated and doesn't respect the PKG_CONFIG
> environment variable which makes it easy to deal with differently
> named pkg-config executables, e.g. arch-prefixed ones.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindLibSpectre.cmake 8d5dc76 
> 
> Diff: https://git.reviewboard.kde.org/r/123393/diff/
> 
> 
> Testing
> -------
> 
> Configured and built okular successfully and checked that it links to libspectre.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150418/4bd28a1f/attachment.html>


More information about the Okular-devel mailing list