[Okular-devel] Review Request 123393: FindLibSpectre: Use FindPkgConfig instead of UsePkgConfig
Albert Astals Cid
aacid at kde.org
Fri Apr 17 22:00:10 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123393/#review79147
-----------------------------------------------------------
what happened to the else for "if not win32"?
- Albert Astals Cid
On abr. 17, 2015, 9:40 a.m., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123393/
> -----------------------------------------------------------
>
> (Updated abr. 17, 2015, 9:40 a.m.)
>
>
> Review request for Okular.
>
>
> Repository: okular
>
>
> Description
> -------
>
> The latter is deprecated and doesn't respect the PKG_CONFIG
> environment variable which makes it easy to deal with differently
> named pkg-config executables, e.g. arch-prefixed ones.
>
>
> Diffs
> -----
>
> cmake/modules/FindLibSpectre.cmake 8d5dc76
>
> Diff: https://git.reviewboard.kde.org/r/123393/diff/
>
>
> Testing
> -------
>
> Configured and built okular successfully and checked that it links to libspectre.
>
>
> Thanks,
>
> Heiko Becker
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150417/c263411d/attachment.html>
More information about the Okular-devel
mailing list