[Okular-devel] Review Request 123314: Use generated version and CMake config files

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123314/#review78932
-----------------------------------------------------------


I have now managed to get Kile to compile after applying the following patch: https://paste.kde.org/pcqb8yjuz and once https://git.reviewboard.kde.org/r/123363/ has been applied


CMakeLists.txt (line 325)
<https://git.reviewboard.kde.org/r/123314/#comment53962>

    I would change this to `NAMESPACE Okular::`



OkularConfig.cmake.in (line 3)
<https://git.reviewboard.kde.org/r/123314/#comment53965>

    This is missing a few dependencies:
    
    ```
    find_dependency(Qt5PrintSupport @QT_REQUIRED_VERSION@)
    find_dependency(Qt5Widgets @QT_REQUIRED_VERSION@)
    find_dependency(KF5CoreAddons @KF5_REQUIRED_VERSION@)
    find_dependency(KF5Config @KF5_REQUIRED_VERSION@)
    find_dependency(KF5XmlGui @KF5_REQUIRED_VERSION@)
    ```


- Alex Richardson


On April 10, 2015, 5:14 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123314/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 5:14 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene Shalygin.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Replace both the package version file by a generated file, as well as OkularConfig.cmake package configuration file.
> Note that with this change the compatibility CMake variable OKULAR_FOUND is not set anymore, use Okular_FOUND instead.
> 
> This patch (should) fix the regression on eg. Gentoo systems introduced by RR #123176
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 56c9976 
>   OkularConfig.cmake 171b845 
>   OkularConfig.cmake.in PRE-CREATION 
>   core/version.h 855df95 
> 
> Diff: https://git.reviewboard.kde.org/r/123314/diff/
> 
> 
> Testing
> -------
> 
> Manual testing on a Debian system
> 
> @Eugene: does it fix the regression for you?
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150414/a97eee0b/attachment.html>