[Okular-devel] Review Request 123314: Use generated version and CMake config files

[Andreas Cord-Landwehr]

> On April 10, 2015, 5:59 nachm., Eugene Shalygin wrote:
> > I cann't say that it fixes the issue. Maybe it does, but I just can not make it working.
> > 
> > I'm testing with Kile. Kile needs access to okular/interfaces/viewerinterface.h. However, this file contains `#include "okularcore_export.h"`. Thus, path to Okular includes is needed. But OKULAR_INCLUDE_DIR is gone.  OK, let's try to do this in the new way. So I add KF5::okularcore target to the dependencies (BTW, why KF5?). But have you seen its INTERFACE_LINK_LIBRARIES property? KF5::Archive;KF5::JS;KF5::JSApi;KF5::KDELibs4Support;KF5::KIOCore;KF5::ThreadWeaver;KF5::Wallet;Phonon::phonon4qt5;m;/usr/lib64/libz.so. Are all of them indeed needed just to link with Okular?
> > 
> > So, what am I doing wrong?
> 
> Alex Richardson wrote:
>     I just looked at some of the frameworks and I think what is needed for the include dirs is
>     
>     ```
>     target_include_directories(okularcore INTERFACE "$<INSTALL_INTERFACE:${KDE_INSTALL_INCLUDEDIR_KF5}>")
>     ```
>     assuming anyone using the library uses `#include <okular/core/document.h>` 
>     
>     
>     Additionally the `#include "okularcore_export.h"` inside the interfaces include dir seems wrong to me, that should probably be `#include "../core/okularcore_export.h"`

Shall I add it to this patch or is it worth another RR?


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123314/#review78774
-----------------------------------------------------------


On April 10, 2015, 4:14 nachm., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123314/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 4:14 nachm.)
> 
> 
> Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene Shalygin.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Replace both the package version file by a generated file, as well as OkularConfig.cmake package configuration file.
> Note that with this change the compatibility CMake variable OKULAR_FOUND is not set anymore, use Okular_FOUND instead.
> 
> This patch (should) fix the regression on eg. Gentoo systems introduced by RR #123176
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 56c9976 
>   OkularConfig.cmake 171b845 
>   OkularConfig.cmake.in PRE-CREATION 
>   core/version.h 855df95 
> 
> Diff: https://git.reviewboard.kde.org/r/123314/diff/
> 
> 
> Testing
> -------
> 
> Manual testing on a Debian system
> 
> @Eugene: does it fix the regression for you?
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150412/bc64017f/attachment.html>