[Okular-devel] Review Request 123176: Fix include and library information of OkularConfig.cmake.

[Andreas Cord-Landwehr]

> On März 29, 2015, 10:42 nachm., Albert Astals Cid wrote:
> > None of the people that did any frameworks branch work seem to be monitoring reviewboard, so i guess i'd say ship it if you know what you're doing :D
> 
> Eugene Shalygin wrote:
>     This change has broke things at least on Gentoo. Here we have OkularConfig.cmake installed into /usr/lib64/cmake/Okular/ and _okularBaseDir is equal to "/", but it has to be equal to "/usr", right? Thus, find_package(Okular) does not work. Reverting the commit fixes the problem.

Just checked on my Debian machine, there we have /usr/lib/x86_64-linux-gnu/cmake/Okular/Okular/config.cmake. This is, the architecture prefix forms a directory compared to the folder-name-suffix as on Gentoo.
Hence we need a different approach to fix this than simply reverting (since reverting will break it again on all Debian-based multiarch systems). IMO probably best is to directly switch to cmake's autogeneration of cmake files. I could look into it this week (if nobody is faster than me).


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123176/#review78190
-----------------------------------------------------------


On März 31, 2015, 4:23 nachm., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123176/
> -----------------------------------------------------------
> 
> (Updated März 31, 2015, 4:23 nachm.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> This fixes two issues:
> 1. ${_okularBaseDir} provides a path to <somedir>/lib which prevents the include dir to be found
> 2. the find_library search does not consider the architecture prefixes (here I am unsure if I fixed it correctly or if NO_DEFAULT_PATH had a deeper meaning)
> 
> 
> Diffs
> -----
> 
>   OkularConfig.cmake 59537c6 
> 
> Diff: https://git.reviewboard.kde.org/r/123176/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150406/b1cac0a6/attachment-0001.html>