[Okular-devel] [okular] [Bug 345765] [OS X] okular crashing opening PDF from URL

[RJVB]

https://bugs.kde.org/show_bug.cgi?id=345765

--- Comment #6 from RJVB <rjvbertin at gmail.com> ---
Looks like it's that indeed. I had to add the block to canOpenDocs too

part= Okular::Part(0x7ffb3e05f9f0) 
okular(56591) Shell::canOpenDocs: part= Okular::Part(0x7ffb3e05f9f0)
dynamic_cast<Okular::ViewerInterface*>(part)= 0x0 
okular(56591) Shell::canOpenDocs: dynamic_cast<Okular::ViewerInterface*>(part)=
0x0
part= Okular::Part(0x7ffb3e05f9f0) 
okular(56591) Shell::openDocument: part= Okular::Part(0x7ffb3e05f9f0)
dynamic_cast<Okular::ViewerInterface*>(part)= 0x0 
okular(56591) Shell::openDocument:
dynamic_cast<Okular::ViewerInterface*>(part)= 0x0

I've encountered something like this before, with ktimetracker. I've never
understood why this happens.

The "good" news is that if I do

    Okular::ViewerInterface *viFace =
dynamic_cast<Okular::ViewerInterface*>(part);
    // Return false if we can't open new tabs and the only part is occupied
    if ( viFace && !viFace->openNewFilesInTabs()
         && !part->url().isEmpty()
         && !ShellUtils::unique(serializedOptions))
    {
        return false;
    }

the document opens, ultimately.

Similar patches in canOpenDoc and openUrl prevent the crash and also the issue
at https://trac.macports.org/ticket/47054

-- 
You are receiving this mail because:
You are the assignee for the bug.