[Okular-devel] Review Request 120307: Keybindings for notes works after closing the search bar

Albert Astals Cid aacid at kde.org
Sun Sep 28 16:19:48 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120307/#review67570
-----------------------------------------------------------


Doesn't look like the best place for focus, see how previously the up/down arrows work but after closing with the [x] does not (but it works if you close with Esc)

- Albert Astals Cid


On set. 21, 2014, 5:10 p.m., Nidhi Jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120307/
> -----------------------------------------------------------
> 
> (Updated set. 21, 2014, 5:10 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 314251
>     http://bugs.kde.org/show_bug.cgi?id=314251
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> After closing the search bar, the focus is moved to the parent Widget.
> 
> 
> Diffs
> -----
> 
>   ui/findbar.cpp f00f883 
> 
> Diff: https://git.reviewboard.kde.org/r/120307/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nidhi Jain
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140928/08eea6cb/attachment.html>


More information about the Okular-devel mailing list