[Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115532/#review66889
-----------------------------------------------------------


Minor nitpick while i find time to review the code, the spacing of lots of places is off, for example

        int m_transitionMul;
        QList< QRect > m_transitionRects;
	Okular::PageTransition m_currentTransition;
	QPixmap m_lastRenderedPixmapCopy;

Please check that you use spaces where we use spaces and tabs where we use tabs (at least in each file)

- Albert Astals Cid


On set. 13, 2014, 6:19 a.m., Saheb Preet Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115532/
> -----------------------------------------------------------
> 
> (Updated set. 13, 2014, 6:19 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 317073
>     http://bugs.kde.org/show_bug.cgi?id=317073
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> implemented fade in and fade out transition for presentation mode in okular.
> 
> 
> Diffs
> -----
> 
>   conf/dlgpresentationbase.ui 31db693 
>   conf/okular.kcfg f980989 
>   ui/presentationwidget.h a99b8ce 
>   ui/presentationwidget.cpp 4aaec2a 
> 
> Diff: https://git.reviewboard.kde.org/r/115532/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Saheb Preet Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140918/19d21703/attachment-0001.html>