[Okular-devel] [okular] [Bug 334251] Tools don't work if any tab is in review mode

[Jonathan Doman]

https://bugs.kde.org/show_bug.cgi?id=334251

--- Comment #3 from Jonathan Doman <jonathan.doman at gmail.com> ---
I took some time to look at this and I'm not sure how to fix it. The problem is
that changing the mouse mode writes the global Settings, which triggers all the
Parts to reload (and potentially overwrite) the Settings. We could:

1. Don't watch for the Settings::configChanged signal. This is my preference,
as I wouldn't expect the program to reload settings whenever the config file is
written to.

2. Don't constantly write settings to disk. Most Settings mutations are
followed by a writeConfig(), which seems unnecessary to me. Why not just
writeConfig() once when the program is exiting?

3. Remove MouseMode as a global setting. Why not just always start the program
in Browse mode?

I would ultimately prefer to get rid of all persistent, implicit settings and
make everything non-configurable or explicitly configurable because I don't
think there's an intuitive way to resolve settings when multiple program
instances are simultaneously altering them.

-- 
You are receiving this mail because:
You are the assignee for the bug.