[Okular-devel] Review Request 120683: Extending AudioPlayer so that it gives info about if something is playing at the moment or not.

[Nidhi Jain]

> On Nov. 11, 2014, 10 p.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 2426
> > <https://git.reviewboard.kde.org/r/120683/diff/1/?file=321185#file321185line2426>
> >
> >     If i select Enqueue it actually stops playing the existing sound instead of enqueinig it.

In the Documentation of audioplayer class, it is mentioned that playsound method will handle enqueue operation. But it seems that enqueue operation is handled by that function.


- Nidhi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120683/#review70257
-----------------------------------------------------------


On Oct. 21, 2014, 12:25 p.m., Nidhi Jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120683/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 12:25 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 326536
>     http://bugs.kde.org/show_bug.cgi?id=326536
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> When  right clicked on an AudioLink instead of "Follow This Link" it should say "Play this Sound" if nothing is playing or "Enqueue This Sound" if something is playing. Also "Stop Sound" appears only if something is actually playing. 
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 39a9390 
> 
> Diff: https://git.reviewboard.kde.org/r/120683/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nidhi Jain
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20141112/ee5ce507/attachment.html>