[Okular-devel] Review Request 118171: Fix for bug 118171 - crash when clicking in a text form that is not editable

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118171/#review58206
-----------------------------------------------------------


This review has been submitted with commit 34dc4eb22eb5e020e667d729c86d8900bb3e4fa3 by Albert Astals Cid on behalf of Jon Mease to branch KDE/4.13.

- Commit Hook


On May 16, 2014, 5:47 p.m., Jon Mease wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118171/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 5:47 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 334611
>     http://bugs.kde.org/show_bug.cgi?id=334611
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Fix for bug 334611 - Crash when clicking in a text form that is not editable.
> Solution is to not connect the undo/redo support signals for read-only form fields.
> 
> 
> Diffs
> -----
> 
>   ui/formwidgets.cpp 023a25f 
> 
> Diff: https://git.reviewboard.kde.org/r/118171/diff/
> 
> 
> Testing
> -------
> 
> Okular no longer crashes when selecting text from the read only text field in the PDF supplied with the bug report
> 
> 
> Thanks,
> 
> Jon Mease
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140520/63bb4815/attachment.html>