[Okular-devel] Review Request 117267: make width of the rectangle for inline note in annotations configurable

[Albert Astals Cid]

> On April 27, 2014, 8:34 p.m., Albert Astals Cid wrote:
> > core/annotations.cpp, line 744
> > <https://git.reviewboard.kde.org/r/117267/diff/1/?file=262125#file262125line744>
> >
> >     Why this change?
> 
> Alin M Elena wrote:
>     Hi,
>     
>     A hangover from some tests I did... We can revert it to integer 1 if you want.
>     
>     regards,
>     Alin

Yes please, let's leave only the changes we really need so that when in a few years people look at the diff they don't wonder why this change was introduced/needed.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117267/#review56692
-----------------------------------------------------------


On March 31, 2014, 10:48 p.m., Alin M Elena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117267/
> -----------------------------------------------------------
> 
> (Updated March 31, 2014, 10:48 p.m.)
> 
> 
> Review request for Okular and Fabio D'Urso.
> 
> 
> Bugs: 332887
>     http://bugs.kde.org/show_bug.cgi?id=332887
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> make width of the rectangle for inline note in annotations configurable
> promised it to fabio few months back... never got the time to it till now
> 
> 
> Diffs
> -----
> 
>   core/annotations.cpp e029946 
>   ui/annotationwidgets.h 6e7a218 
>   ui/annotationwidgets.cpp 450e50b 
> 
> Diff: https://git.reviewboard.kde.org/r/117267/diff/
> 
> 
> Testing
> -------
> 
> saved a document with various widths for border from 0 to more... opened it in windows acroread and worked.
> 
> 
> Thanks,
> 
> Alin M Elena
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140502/6cdd3f9a/attachment.html>