[Okular-devel] Review Request 116700: Launch documents from external sources in new tabs

[Jonathan Doman]

> On March 17, 2014, 7:45 p.m., Albert Astals Cid wrote:
> > shell/main.cpp, line 51
> > <https://git.reviewboard.kde.org/r/116700/diff/1/?file=253226#file253226line51>
> >
> >     Should you bail out early of this function if the shell is configured to not open in tabs?

Maybe. Currently, this check is handled per-process in canOpenDocs. I did this so that a non-tabbed window with no open documents (1 empty part) would be able to handle a single doc. Also, since config settings are not fully synced until the okular is fully restarted, this allows a window that was originally non-tabbed to change that setting and then handle multiple docs without restarting (or the other way around).

I think the current logic results in more intuitive behavior, but you may disagree.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116700/#review53284
-----------------------------------------------------------


On March 10, 2014, 5:45 p.m., Jonathan Doman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116700/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 5:45 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 331872
>     http://bugs.kde.org/show_bug.cgi?id=331872
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Currently, tabs can only be created by opening files through okular's file dialog. This patch allows external sources (e.g. file browsers) to open documents in tabs of existing windows.
> 
> Basically, whenever okular is launched it uses D-Bus to search for existing okular instances that are capable of handling its documents. An eligible window will have enough space for all the documents (space depends on whether tabs are allowed or not), and be located on the current desktop. If there are multiple eligible windows, one is chosen "at random" (the first one in the D-Bus listing). This metric can be changed in the future, but is the simplest for now.
> 
> To facilitate the D-Bus interaction, two methods were added: "canOpenDocs" is used to find an eligible window, "openDocument" is used to actually open a single document. Additionally, "tryRaise" was modified to work on non-unique windows.
> 
> I previously thought that okular should behave similar to a web browser, but now I think they are very different. Most people open a web browser and then search and open links completely within it. However, most people will use okular by clicking on files in a file browser. Therefore, I don't think okular should ever open tabs in a window on a different desktop.
> 
> One shortcoming occurs when one wants to open a document in its own window, but instead gets put into a tab. There is no way to "detach" a tab, so it's necessary to then open an empty okular instance and use the file dialog. Detaching tabs should be possible, but I guess there are concerns about how to do so efficiently.
> 
> 
> Diffs
> -----
> 
>   shell/shell.cpp 01a9f1b1dc1992a4aa1c87330940b27b727608e5 
>   shell/shell.h 3b9aae061cd6be0c7a86c885fc06d00d9275bd50 
>   shell/main.cpp e0ca587ba167c4020d5af5bd33a2dc1b4923cac4 
> 
> Diff: https://git.reviewboard.kde.org/r/116700/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Doman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140318/2814ace8/attachment.html>